-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: Add support to filter on teams.listRooms
endpoint
#21327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
requested changes
Mar 29, 2021
server/services/team/service.ts
Outdated
@@ -396,13 +396,13 @@ export class TeamService extends ServiceClass implements ITeamService { | |||
throw new Error('user-not-on-private-team'); | |||
} | |||
if (getAllRooms) { | |||
const teamRoomsCursor = this.RoomsModel.findByTeamId(teamId, { skip, limit }); | |||
const teamRoomsCursor = this.RoomsModel.findByTeamId(teamId, { skip, limit }, query as FilterQuery<IRoom>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to type cast as FilterQuery
=) typescript can already infer that from the param ;)
Suggested change
const teamRoomsCursor = this.RoomsModel.findByTeamId(teamId, { skip, limit }, query as FilterQuery<IRoom>); | |
const teamRoomsCursor = this.RoomsModel.findByTeamId(teamId, { skip, limit }, query); |
server/services/team/service.ts
Outdated
return { | ||
total: await teamRoomsCursor.count(), | ||
records: await teamRoomsCursor.toArray(), | ||
}; | ||
} | ||
const teamRooms = await this.RoomsModel.findByTeamId(teamId, { projection: { _id: 1, t: 1 } }).toArray(); | ||
const teamRooms = await this.RoomsModel.findByTeamId(teamId, { skip, limit, projection: { _id: 1, t: 1 } }, query as FilterQuery<IRoom>).toArray(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
const teamRooms = await this.RoomsModel.findByTeamId(teamId, { skip, limit, projection: { _id: 1, t: 1 } }, query as FilterQuery<IRoom>).toArray(); | |
const teamRooms = await this.RoomsModel.findByTeamId(teamId, { skip, limit, projection: { _id: 1, t: 1 } }, query).toArray(); |
sampaiodiego
approved these changes
Mar 29, 2021
sampaiodiego
changed the title
[IMPROVE] teams.listRooms endpoint doesn't support queries
Regression: Add support to filter on Mar 29, 2021
teams.listRooms
endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
query
parameter);offset
andcount
) when an user doesn't have the permission to get all rooms.Issue(s)
Task - ClickUp
Steps to test or reproduce
Example input (using cURL):
Further comments