Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: New chat forwarding modal is not verifying mandatory values #21288

Merged
merged 7 commits into from
Mar 30, 2021
Merged

Regression: New chat forwarding modal is not verifying mandatory values #21288

merged 7 commits into from
Mar 30, 2021

Conversation

rafaelblink
Copy link
Contributor

@rafaelblink rafaelblink commented Mar 24, 2021 •
edited
Loading

Proposed changes (including videos or screenshots)

The Forward Chat modal isn't working properly, it's coming a success message but it's not forwarding.

Issue(s)

Steps to test or reproduce

Further comments

@rafaelblink rafaelblink marked this pull request as ready for review March 25, 2021 11:50
renatobecker
renatobecker requested changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@renatobecker renatobecker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When filtering users, the endpoint should return only users with statusLivechat === available and status !== offline.

Please add this filter to the endpoint when fetching data.

@renatobecker renatobecker changed the title Regression: Forward conversation isn't working properly. Regression: New chat forwarding modal is not verifying mandatory values Mar 30, 2021
@renatobecker renatobecker merged commit fb51742 into develop Mar 30, 2021
@renatobecker renatobecker deleted the omnichannel/forward-issue-reg branch March 30, 2021 16:06
@sampaiodiego sampaiodiego mentioned this pull request Apr 3, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatobecker renatobecker renatobecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaelblink @renatobecker