Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Quick action button missing for Omnichannel On-Hold queue #21285

Merged
merged 20 commits into from
Mar 31, 2021

Conversation

murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Mar 24, 2021

Proposed changes (including videos or screenshots)

  • Move the Manual On Hold button to the new Omnichannel Header
    image
    image

  • Minor fixes

Issue(s)

Steps to test or reproduce

Further comments

@murtaza98 murtaza98 marked this pull request as draft March 24, 2021 11:50
Copy link
Contributor

@renatobecker renatobecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files are not placed inside the EE folder.

@murtaza98 murtaza98 marked this pull request as ready for review March 24, 2021 18:47
@murtaza98
Copy link
Contributor Author

murtaza98 commented Mar 24, 2021

The files are not placed inside the EE folder.

@renatobecker I was able to move some of the client files to EE folder. Because of this change, the on-hold feature would work on EE only. Please let me know if there is a way to move the other changes to the EE folder too.

@murtaza98 murtaza98 requested a review from renatobecker March 24, 2021 19:03
@murtaza98 murtaza98 requested a review from renatobecker March 26, 2021 18:14
@renatobecker renatobecker changed the title [Regression][Enterprise] Omnichannel On-Hold queue Regression: New quick action button missing for Omnichannel On-Hold queue Mar 26, 2021
@murtaza98 murtaza98 marked this pull request as draft March 30, 2021 12:32
@renatobecker renatobecker changed the title Regression: New quick action button missing for Omnichannel On-Hold queue Regression: Quick action button missing for Omnichannel On-Hold queue Mar 30, 2021
@murtaza98 murtaza98 marked this pull request as ready for review March 30, 2021 12:39
Copy link
Contributor

@renatobecker renatobecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@murtaza98 regarding the button and icon missing, are you still working on it?

@murtaza98
Copy link
Contributor Author

@murtaza98 regarding the button and icon missing, are you still working on it?

Hey @renatobecker Thanks for the reminder. I've added it now 😄

@murtaza98 murtaza98 requested a review from renatobecker March 30, 2021 18:18
@murtaza98 murtaza98 added this to the 3.13.0 milestone Mar 31, 2021
@renatobecker renatobecker merged commit cca963a into develop Mar 31, 2021
@renatobecker renatobecker deleted the omnichannel/on-hold-reg-1 branch March 31, 2021 14:43
gabriellsh added a commit that referenced this pull request Mar 31, 2021
…team_permi

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Quick action button missing for Omnichannel On-Hold queue (#21285)
  Regression: team roles are created separately from regular roles but not being used anywhere (#21376)
  Regression: Contact Chat History component not visible (#21316)
@sampaiodiego sampaiodiego mentioned this pull request Apr 3, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants