Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Set establishing to false if OTR timeouts #21183

Merged
merged 1 commit into from
Mar 23, 2021
Merged

[FIX] Set establishing to false if OTR timeouts #21183

merged 1 commit into from
Mar 23, 2021

Conversation

Darshilp326
Copy link
Contributor

@Darshilp326 Darshilp326 commented Mar 18, 2021 •
edited
Loading

Proposed changes (including videos or screenshots)

Set establishing false if OTR timeouts.

OTR-pr.mp4

Issue(s)

Closes #21121

Steps to test or reproduce

Further comments

@Darshilp326 Darshilp326 changed the title [FIX] Set establishing to false after OTR timeout [FIX] Set establishing to false if OTR timeouts Mar 18, 2021
mcaj
mcaj approved these changes Mar 19, 2021
View reviewed changes
Copy link

@mcaj mcaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
We are having problem with missing timeout in OTR since
last update.

@ggazzo ggazzo merged commit 716913a into RocketChat:develop Mar 23, 2021
@sampaiodiego sampaiodiego mentioned this pull request Apr 3, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@mcaj mcaj mcaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not restart OTR if timed out - Please wait while OTR is being established
3 participants
@Darshilp326 @mcaj @ggazzo