Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Ensure E2E is enabled/disabled on sending message #21084

Merged
merged 5 commits into from
Mar 23, 2021
Merged

[FIX] Ensure E2E is enabled/disabled on sending message #21084

merged 5 commits into from
Mar 23, 2021

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Mar 11, 2021 •
edited
Loading

Proposed changes (including videos or screenshots)

Rooms which were encrypted somewhere in the past still could encrypt messages due to a race condition due to a query over Subscriptions collection.

Issue(s)

Steps to test or reproduce

  1. Enable encryption in a room;
  2. Disable afterwards;
  3. Refresh the page and send a message, many times.

Further comments

@tassoevan tassoevan requested a review from a team March 12, 2021 13:56
@tassoevan tassoevan added this to the 3.12.2 milestone Mar 12, 2021
@tassoevan tassoevan changed the title fix/e2e [FIX] Ensure E2E is enabled/disabled on sending message Mar 12, 2021
@tassoevan tassoevan marked this pull request as ready for review March 12, 2021 14:00
@ggazzo ggazzo merged commit 7ccb790 into develop Mar 23, 2021
@ggazzo ggazzo deleted the fix/e2e branch March 23, 2021 03:10
@sampaiodiego sampaiodiego mentioned this pull request Apr 3, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.12.2
Development

Successfully merging this pull request may close these issues.
2 participants
@tassoevan @ggazzo