[FIX] Missing app permissions translation #21066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-gubert
commented
Mar 10, 2021
| @@ -464,6 +464,7 @@ | |||
| "Apps_Marketplace_Uninstall_Subscribed_App_Prompt": "This app has an active subscription and uninstalling will not cancel it. If you'd like to do that, please modify your subscription before uninstalling.", | |||
| "Apps_Permissions_Review_Modal_Title": "This app requires the following permissions", | |||
| "Apps_Permissions_No_Permissions_Required": "The App does not require additional permissions", | |||
| "Apps_Permissions_cloud_workspace-token": "Interact with Cloud Services on behalf of this server", | |||
There was a problem hiding this comment.
@geekgonecrazy not sure about the wording here... are we calling this the "Cloud Services"? 🤔
There was a problem hiding this comment.
I think this is accurate. Not sure what alternative would be. Since it does actually mean could talk to any of our cloud services.
There was a problem hiding this comment.
Just wondering if people will know what we're referring to 😛
geekgonecrazy
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Add missing translations for some app permissions
Issue(s)
Steps to test or reproduce
Further comments