Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] [APPS] Warn message while installing app in air-gapped environment #20992

Merged
merged 3 commits into from
Mar 22, 2021

Conversation

lucassartor
Copy link
Contributor

Proposed changes (including videos or screenshots)

Change error message to a warn message when uploading a .zip file app into a air-gapped environment.

The error message was giving the impression for the user that the app wasn't properly being installed , which it wasn't the case:
error

A more detailed warn message can fix that impression for the user:
warn

Issue(s)

Fixes Task

Steps to test or reproduce

  1. Go to Admin > Logs and change the log level to at least 1 (warn messages are level 1)
  2. Cut the internet connection from a Rocket Chat server
  3. Upload a .zip app file and installed it
  4. The message will appear in the console

Further comments

app/apps/server/communication/rest.js Outdated Show resolved Hide resolved
app/apps/server/communication/rest.js Outdated Show resolved Hide resolved
app/apps/server/communication/rest.js Outdated Show resolved Hide resolved
app/apps/server/communication/rest.js Outdated Show resolved Hide resolved
Copy link
Member

@d-gubert d-gubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@d-gubert d-gubert added this to the 3.13.0 milestone Mar 8, 2021
@ggazzo ggazzo merged commit 5f8fb18 into develop Mar 22, 2021
@ggazzo ggazzo deleted the apps/task/376x06 branch March 22, 2021 22:57
@sampaiodiego sampaiodiego mentioned this pull request Apr 3, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants