-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVE] Sort Users List In Case Insensitive Manner #20790
Merged
ggazzo
merged 12 commits into
RocketChat:develop
from
aditya-mitra:aditya-mitra-sort-users-admin
Mar 22, 2021
Merged
[IMPROVE] Sort Users List In Case Insensitive Manner #20790
ggazzo
merged 12 commits into
RocketChat:develop
from
aditya-mitra:aditya-mitra-sort-users-admin
Mar 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevLehman
reviewed
Feb 17, 2021
I know this is Out of scope for this ticket, but, is this also happening with Room names? If so, we'd need to create an issue for that. |
I will check that for sure! |
aditya-mitra
force-pushed
the
aditya-mitra-sort-users-admin
branch
5 times, most recently
from
February 19, 2021 04:02
58df41d
to
ca38192
Compare
KevLehman
requested changes
Feb 19, 2021
aditya-mitra
force-pushed
the
aditya-mitra-sort-users-admin
branch
from
February 19, 2021 13:33
aaaf682
to
f117322
Compare
KevLehman
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The users listed in the admin panel were sorted in a case-sensitive manner , where the capitals came first and then the small letters (like - A B C a b c). This Change fixes this by sorting the names in a caseinsensitive manner (now - A a B b C c).
Before
With This Change
Issue(s)
Closes #14735
Steps to test or reproduce
Further comments
user.list.sorting.in.case.insensitive.manner.mp4