Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Make custom emoji file required #19583

Merged

Conversation

m-shreyansh
Copy link
Contributor

@m-shreyansh m-shreyansh commented Nov 18, 2020

Proposed changes

Do not allow custom emoji if file is not uploaded for it.

Issue(s)

Fixes #19343

Screenshots

bug-fix

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Adding a file for custom emoji is now a must to create a new emoji.

@CLAassistant
Copy link

CLAassistant commented Nov 18, 2020

CLA assistant check
All committers have signed the CLA.

@ggazzo ggazzo changed the title [FIX] Make custom emoji icon necessary [FIX] Make custom emoji file required Mar 23, 2021
@ggazzo ggazzo merged commit 5f98a21 into RocketChat:develop Mar 23, 2021
@m-shreyansh m-shreyansh deleted the make-custom-emoji-icon-necessary branch March 24, 2021 17:32
@m-shreyansh m-shreyansh restored the make-custom-emoji-icon-necessary branch March 24, 2021 17:32
@sampaiodiego sampaiodiego mentioned this pull request Apr 3, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Emoji can be empty
3 participants