[FIX] Create Custom OAuth services from environment variables

[mrtndwrd]

Closes #10420

This PR adds a function customOAuthServicesInit() that checks if there are environment variables set for custom OAuth services. If they are set, they get added to the settings.

Without this function, these environment variables are only parsed and added to settings after the custom OAuth service is created through the administration interface.

I currently call this function in the oAuthServicesUpdate.js file. I'm not sure if this is the best way to call a start-up function. All suggestions for improvement are more than welcome!

[CLAassistant]

All committers have signed the CLA.

[mrtndwrd]

It seems the build-image-pr test failed due to something I didn't change. Is there anything I can do to fix this, or maybe retrigger the build?

[varac]

Dear Rocket.Chat devs, can anybody please review ? This is a very needed and useful feature.

[mrtndwrd]

@engelgabriel I have the feeling this PR might have slipped through the cracks. I would really like to have it reviewed and merged, because now I'm maintaining a fork of Rocket.Chat. As can be seen in #10420 I'm also not the only one that runs into the problem that this PR solves.

Is there anything I can do to help you start or speed up the review process? Thank you!

[varac]

Ping

[mrtndwrd]

@sampaiodiego you seemed to have an interest in #10420 (you put it on the todo list). Is there anything I can do to help speed up the review process a bit?

[sampaiodiego]

thanks @mrtndwrd .. I'll ask @pierre-lehnen-rc to review it for next release 👍

[mrtndwrd]

Thank you for merging!

[geekgonecrazy]

@mrtndwrd did you manage to actually use this? I'm fighting with every shell I try with rejecting environment variables with a - in them.

I'm wondering if we don't need to make this more clever and match on all underscore and transform

[mrtndwrd]

You're right, I can't think of a shell that will allow dashes in the environment variable name.

I can tell you that this does work if you install rocket.chat with the helm chart. You need to set the extraEnv variable to set the variables used here. I can imagine you can do something similar with Docker or Docker-compose, but I haven't tried.

The way I use it is a bit complicated, but it boils down to that this is the helm values file we use: https://open.greenhost.net/openappstack/openappstack/-/blob/master/ansible/roles/apps/templates/settings/rocketchat.yaml (templated by ansible, don't ask me why 😅)