[FIX] Horizontal scroll on user info tab #12102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rssilva
force-pushed
the
fix/user-bar-scroll
branch
from
2a3053e
to
f140534
Compare
ggazzo
previously approved these changes
Sep 19, 2018
2 tasks
rssilva
force-pushed
the
fix/user-bar-scroll
branch
from
ef16514
to
c2c8580
Compare
tassoevan
reviewed
Sep 24, 2018
| @@ -176,6 +176,8 @@ | |||
| &__item { | |||
| overflow: hidden; | |||
|
|
|||
| max-width: 45%; | |||
There was a problem hiding this comment.
Why is this better than adding overflow: hidden in the parent element (.rc-user-info-action)?
There was a problem hiding this comment.
It isn't! I changed 😄 now! Thank you 🙌
tassoevan
approved these changes
Sep 24, 2018
sampaiodiego
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11961
I'm fixing errors on modal.css to avoid build breaking