-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVE] New emails design #12009
[IMPROVE] New emails design #12009
Conversation
940726e
to
cb5fadc
Compare
cb5fadc
to
106fd61
Compare
]); | ||
Npm.depends({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -555,6 +553,7 @@ | |||
"Compact": "Compact", | |||
"Condensed": "Condensed", | |||
"Computer": "Computer", | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove empty line
@@ -1220,6 +1219,7 @@ | |||
"Force_SSL": "Force SSL", | |||
"Force_SSL_Description": "*Caution!* _Force SSL_ should never be used with reverse proxy. If you have a reverse proxy, you should do the redirect THERE. This option exists for deployments like Heroku, that does not allow the redirect configuration at the reverse proxy.", | |||
"Forgot_password": "Forgot your password", | |||
"Forgot_password_ask": "Forgot your password?", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't add a new key, use the one above.
@@ -1663,6 +1664,7 @@ | |||
"Log_View_Limit": "Log View Limit", | |||
"Logged_out_of_other_clients_successfully": "Logged out of other clients successfully", | |||
"Login": "Login", | |||
"Login_now": "Login now", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't add a new key, use the one above.
@@ -2146,6 +2148,7 @@ | |||
"Require_password_change": "Require password change", | |||
"Resend_verification_email": "Resend verification email", | |||
"Reset": "Reset", | |||
"Reset_now": "Reset now", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't add a new key, use the one above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thiagosanchz what do you think about change that texts(remove the now
)? I really like the now words :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@engelgabriel @ggazzo Why we can't add new words? I think the word NOW emphasizes the action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thiagosanchz @ggazzo @brunosquadros @sampaiodiego let's not create new translation keys like this, that are important and don't add much to the user experience. Every new KEY will have to be translated into 50 languages and maintained. We already have far more keys that we need and we have a big mess because of it. We are trying to reduce the number of redundant translation keys.
setTimeout(() => { | ||
RocketChat.settings.get('Accounts_UserAddedEmail', (key, value) => { | ||
body = inlinecss(value); | ||
console.log(body); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this for debug?
@ggazzo Is it OK in RTL mode? |
@@ -1,9 +1,11 @@ | |||
import _ from 'underscore'; | |||
import moment from 'moment'; | |||
import { send as sendEmail, checkEmail } from 'meteor/rocketchat:mailer'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's nos use "as sendEmail" and keep the names the same everywhere for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1346,6 +1346,7 @@ | |||
"If_you_are_sure_type_in_your_password": "If you are sure type in your password:", | |||
"If_you_are_sure_type_in_your_username": "If you are sure type in your username:", | |||
"If_you_dont_have_one_send_an_email_to_omni_rocketchat_to_get_yours": "If you don't have one send an email to [[email protected]](mailto:[email protected]) to get yours.", | |||
"If_you_didnt_ask_for_reset_ignore_this_email" : "If you didn't ask for reset your password, don't worry, just ignore this email", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you didn't ask for your password reset, don't worry, just ignore this email
would be more proper placement of reset.
If you didn't ask for your password reset, you can ignore this email.
But to me this would be better 🔝
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't think we should say to ignore 😛 it might indicate a tentative of account steal.
@@ -2780,13 +2780,14 @@ | |||
"UTF8_Names_Validation": "UTF8 Names Validation", | |||
"UTF8_Names_Validation_Description": "RegExp that will be used to validate usernames and channel names", | |||
"Validate_email_address": "Validate Email Address", | |||
"Verification_email_body": "You have succesfully created an account on [Site_Name]. Please, click on the button bellow to confirm your email address and finish your registration", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bellow -> below
and i'd change:
to confirm your email address and finish your registration
to
to confirm your email address and finish registration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bellow -> below
🤦♂️ I was so confident it was bellow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😁 to Bellow is to yell or roar but in a deep voice
…at into new-email-templates
1c761fe
to
0bafc82
Compare
ps: its not done yet (even the prints) ;)
welcome screen
confirm email
mail messages
forgot password
invitation email
fix I18n
welcome screen
confirm email
forgot password
mail messages
invitation email