[FIX] Wrong build path in install.sh #11879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
previously approved these changes
Aug 27, 2018
rodrigok
changed the title
rodrigok
approved these changes
Aug 27, 2018
sampaiodiego
requested changes
Sep 3, 2018
| tar zxf rocket.chat.tgz && rm rocket.chat.tgz | ||
| gpg --keyserver ha.pool.sks-keyservers.net --recv-keys 0E163286C20D07B9787EBE9FD7F9D0414FD08104 | ||
|
|
||
| curl -SLf "https://releases.rocket.chat/latest/download/" -o rocket.chat.tgz |
There was a problem hiding this comment.
the develop release is actually at https://releases.rocket.chat/develop/download/ .. or did you change to latest on purpose?
There was a problem hiding this comment.
Since it's a script never used, and wouldn't be updated between master and develop I figured it better to have anyone using it to actually install latest stable
sampaiodiego
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Hackerone report