Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Files list missing from popover menu when owner of room #11565

Merged
merged 5 commits into from
Sep 27, 2018

Conversation

tassoevan
Copy link
Contributor

Closes #11105

Replacing this with Template.instance() in helpers fixed the problem.

@tassoevan tassoevan added this to the 0.68.0 milestone Jul 25, 2018
@tassoevan tassoevan requested a review from ggazzo July 25, 2018 19:36
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11565 July 25, 2018 19:37 Inactive
@theorenck theorenck modified the milestones: 0.68.0, Short-term Jul 31, 2018
ggazzo
ggazzo previously requested changes Aug 16, 2018
@@ -73,69 +73,69 @@ Template.flexTabBar.helpers({
});
},

embeddedVersion() {
embeddVersion() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eww, a random deletion...

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11565 August 16, 2018 20:47 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11565 August 16, 2018 21:24 Inactive
Copy link
Contributor

@geekgonecrazy geekgonecrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be great to get in

@geekgonecrazy geekgonecrazy changed the title [FIX] Popover of "More" rooms actions [FIX] Files list missing from popover menu when owner of room Sep 27, 2018
@geekgonecrazy geekgonecrazy merged commit 9328207 into develop Sep 27, 2018
@geekgonecrazy geekgonecrazy deleted the fix.flex-tab-buttons branch September 27, 2018 16:12
This was referenced Sep 28, 2018
@theorenck theorenck removed this from the Short-term milestone Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files List icon in private channels not visible when user is owner
5 participants