Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Allow multiple subcommands in MIGRATION_VERSION env variable #11184

Merged
merged 2 commits into from
Sep 21, 2018

Conversation

arch119
Copy link
Contributor

@arch119 arch119 commented Jun 19, 2018

This is minor patch to allow multiple subcommands in the env var named "MIGRATION_VERSION" that is read by the DB Migration script. I have also replaced the occurrence of what I believe is now obsolete "MIGRATE" env var in some comments.

Background:
Currently, MIGRATION_VERSION supports a single command like "rerun", "exit" . There are cases, when we want to rerun a specific DB migration script and exit right away. This requires a combination of both "rerun" and "exit" to be passed in. This could be better than creating another subcommand that does the combination of both. The change should also be backwards compatible.

@CLAassistant
Copy link

CLAassistant commented Jun 19, 2018

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ arch119
❌ Shambhu Shrestha


Shambhu Shrestha seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@geekgonecrazy
Copy link
Contributor

@sampaiodiego this looks like a pretty useful addition to the code you added. What do you think?

@sampaiodiego
Copy link
Member

oh.. yes it is. awesome.

@sampaiodiego
Copy link
Member

@arch119 since there is a commit from Shambhu Shrestha, he needs to sign the CLA. do you know him?

@sampaiodiego
Copy link
Member

@arch119 do you know Shambhu Shrestha? we need him to sign the CLA.. otherwise you can do a commit with the changes yourself 😃

@sampaiodiego sampaiodiego merged commit 4e058e5 into RocketChat:develop Sep 21, 2018
This was referenced Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants