Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Desktop notifications not displayed when agent has not focussed the browser #10220

Closed
wants to merge 2 commits into from

Conversation

renatobecker-zz
Copy link

@RocketChat/core

Closes #10074

This PR fixes the bug related to desktop notifications in LiveChat rooms. When a visitor was sending messages and the agent was not focused on the browser, desktop notifications were not displayed to the agent.

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ renatobecker
❌ Renato Becker


Renato Becker seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-10220 March 26, 2018 18:27 Abandoned
@renatobecker-zz renatobecker-zz deleted the no-desktop-notifications-in-livechat branch March 26, 2018 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] No desktop notifications in livechat
4 participants