Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star messages as favorites and have somewhere to see all starred messages #310

Closed
marceloschmidt opened this issue Jul 16, 2015 · 9 comments
Assignees

Comments

@marceloschmidt
Copy link
Member

No description provided.

@engelgabriel engelgabriel added this to the v1.1 milestone Jul 16, 2015
@rodrigok rodrigok modified the milestones: v1.1, Next Aug 15, 2015
@marceloschmidt marceloschmidt self-assigned this Sep 16, 2015
@marceloschmidt
Copy link
Member Author

Adding another icon for starring a message (and later on pinning) will break our layout.

This is ok:
image

But this is not:
image

What can we do? Add only one icon with dropdown? We haven't decided if we are going with a specific dropdown package yet, have we?

cc: @RocketChat/owners

@geekgonecrazy
Copy link
Contributor

yeah we've almost got to get a method for the drop down figured out :( No way we can fit more then one icon over there

@engelgabriel
Copy link
Member

I hate drop down.. but I can't think of a better solution :(

@geekgonecrazy
Copy link
Contributor

What if dropdown desktop and use the popover on long press that's in place for reporting?

@engelgabriel
Copy link
Member

Agreed.. that's the best option I can think of.

On the mobile.. the long hold it the only option really... on the desktop.. I wish I could think of something better.

@marceloschmidt
Copy link
Member Author

Depends on #828

@gmsecrieru
Copy link
Contributor

How is this going so far? I believe this is a very requested feature and I have time to help if needed :D

@geekgonecrazy
Copy link
Contributor

@gmsecrieru I resynced the branch recently. But @marceloschmidt has done most of it.

@gmsecrieru
Copy link
Contributor

Closing as this was already merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants