Regression: Remove added mentions on quote/reply (#10571)

RocketChat · Apr 24, 2018 · cf277bc · cf277bc
1 parent fda38bb
commit cf277bc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/packages/rocketchat-lib/client/MessageAction.js b/packages/rocketchat-lib/client/MessageAction.js
@@ -114,9 +114,9 @@ Meteor.startup(function() {
 		action() {
 			const message = this._arguments[1];
 			const {input} = chatMessages[message.rid];
-			input.value = `@${ message.u.username } `;
 			$(input)
 				.focus()
+				.data('mention-user', true)
 				.data('reply', message)
 				.trigger('dataChange');
 		},
@@ -277,6 +277,7 @@ Meteor.startup(function() {
 			const {input} = chatMessages[message.rid];
 			$(input)
 				.focus()
+				.data('mention-user', false)
 				.data('reply', message)
 				.trigger('dataChange');
 		},

diff --git a/packages/rocketchat-ui/client/lib/chatMessages.js b/packages/rocketchat-ui/client/lib/chatMessages.js
@@ -187,11 +187,13 @@ this.ChatMessages = class ChatMessages {
 
 			let msg = '';
 			const reply = $(input).data('reply');
-			if (reply!==undefined) {
+			const mentionUser = $(input).data('mention-user') || false;
+
+			if (reply !== undefined) {
 				const url = RocketChat.MessageAction.getPermaLink(reply._id);
 				msg = `[ ](${ url }) `;
 				const roomInfo = RocketChat.models.Rooms.findOne(reply.rid, { fields: { t: 1 } });
-				if (roomInfo.t !== 'd' && reply.u.username !== Meteor.user().username) {
+				if (roomInfo.t !== 'd' && reply.u.username !== Meteor.user().username && mentionUser) {
 					msg += `@${ reply.u.username } `;
 				}
 			}