remove unneeded mongo operations

RocketChat · Nov 13, 2024 · 98246f9 · 98246f9
1 parent ea08d74
commit 98246f9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/apps/meteor/app/livechat/server/lib/contacts/addContactEmail.ts b/apps/meteor/app/livechat/server/lib/contacts/addContactEmail.ts
@@ -10,15 +10,11 @@ import { LivechatContacts } from '@rocket.chat/models';
  * @returns the updated contact
  */
 export async function addContactEmail(contactId: ILivechatContact['_id'], email: string): Promise<ILivechatContact> {
-	const contact = await LivechatContacts.findOneById(contactId);
+	const contact = await LivechatContacts.addEmail(contactId, email);
+
 	if (!contact) {
 		throw new Error('error-contact-not-found');
 	}
 
-	const emails = contact.emails?.map(({ address }) => address) || [];
-	if (!emails.includes(email)) {
-		return LivechatContacts.addEmail(contactId, email) as Promise<ILivechatContact>;
-	}
-
 	return contact;
 }
diff --git a/apps/meteor/server/models/raw/LivechatContacts.ts b/apps/meteor/server/models/raw/LivechatContacts.ts
@@ -234,7 +234,7 @@ export class LivechatContactsRaw extends BaseRaw<ILivechatContact> implements IL
 	}
 
 	async addEmail(contactId: string, email: string): Promise<ILivechatContact | null> {
-		const updatedContact = await this.findOneAndUpdate({ _id: contactId }, { $push: { emails: { address: email } } });
+		const updatedContact = await this.findOneAndUpdate({ _id: contactId }, { $addToSet: { emails: { address: email } } });
 
 		return updatedContact.value;
 	}