Skip to content

Commit

Permalink
[NEW][Apps] Add support to the "encoding" option in http requests fro…
Browse files Browse the repository at this point in the history
…m Apps (#19002)

* Allow specify the encoding of the response data

* Update Apps-Engine version

Co-authored-by: Douglas Gubert <[email protected]>
Co-authored-by: Douglas Gubert <[email protected]>
  • Loading branch information
3 people authored Sep 28, 2020
1 parent 2ee3bc4 commit 77f2b51
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 50 deletions.
5 changes: 5 additions & 0 deletions app/apps/server/bridges/http.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ import { HTTP } from 'meteor/http';
function normalizeHttpOptions(options) {
const npmRequestOptions = {};

if (options.hasOwnProperty('encoding')) {
npmRequestOptions.encoding = options.encoding;
delete options.encoding;
}

if (options.hasOwnProperty('strictSSL')) {
npmRequestOptions.strictSSL = options.strictSSL;
delete options.strictSSL;
Expand Down
63 changes: 14 additions & 49 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
"@nivo/heatmap": "^0.61.0",
"@nivo/line": "^0.61.1",
"@nivo/pie": "^0.61.1",
"@rocket.chat/apps-engine": "1.18.0-beta.3848",
"@rocket.chat/apps-engine": "1.18.0-beta.3861",
"@rocket.chat/css-in-js": "^0.14.1",
"@rocket.chat/fuselage": "^0.14.1",
"@rocket.chat/fuselage-hooks": "^0.14.1",
Expand Down

0 comments on commit 77f2b51

Please sign in to comment.