Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: File encryption support #5678

Merged
merged 100 commits into from
Jul 10, 2024
Merged

feat: File encryption support #5678

merged 100 commits into from
Jul 10, 2024

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented May 14, 2024

Proposed changes

Mobile implementation of file encryption support

Issue(s)

Depends on RocketChat/Rocket.Chat#32316

How to test or reproduce

Required to test file encryption: a server running RocketChat/Rocket.Chat#32316

Upload

  • Upload types: image, video, audio, and other file types (PDF, doc, etc)
  • Encryption: On and Off

Others:

  • SSL Client Certificate (upload)
  • Upload of bigger files (100MB)
  • Share extension is disabled
  • Upload progress bar: cancel, try again
  • Media auto download (cache) of encrypted files
  • Backwards compatibility (6.8 and older): all of this need to work on older servers and need to be tested
  • Test everything on Android and iOS

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

E2EE2-7

@diegolmello diegolmello merged commit f228d04 into develop Jul 10, 2024
24 of 25 checks passed
@diegolmello diegolmello deleted the feat.encrypt-file branch July 10, 2024 17:51
diegolmello added a commit to RocketChat/react-native-simple-crypto that referenced this pull request Jul 22, 2024
diegolmello added a commit to RocketChat/react-native-simple-crypto that referenced this pull request Jul 22, 2024
diegolmello added a commit to RocketChat/react-native-simple-crypto that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants