Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: disable notifiee handler on ios devices #5619

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Conversation

dnlsilva
Copy link
Contributor

@dnlsilva dnlsilva commented Mar 18, 2024

Proposed changes

The notification handler overwrites the handler used by the app's notification library, as we don't use notifications from the notification lib on iOS devices, disabling it solves the deeplink problem when the app is in the background.

Issue(s)

How to test or reproduce

  • click on a push with the app in the background

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Jira: [https://rocketchat.atlassian.net/browse/CORE-203]

@dnlsilva dnlsilva changed the title chore: test ios push fix: disable notifiee handler on ios devices Mar 19, 2024
@dnlsilva dnlsilva changed the title fix: disable notifiee handler on ios devices regression: disable notifiee handler on ios devices Mar 19, 2024
@dnlsilva dnlsilva marked this pull request as ready for review March 19, 2024 12:03
@dnlsilva dnlsilva merged commit 4ca6412 into develop Mar 19, 2024
3 of 8 checks passed
@dnlsilva dnlsilva deleted the fix-ios-push branch March 19, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants