Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix unread count on Header and roomListView #5588

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Conversation

dnlsilva
Copy link
Contributor

@dnlsilva dnlsilva commented Feb 21, 2024

Proposed changes

Currently the app was not correctly considering the hideUnreadStatus property for two different scenarios:

  • In header unread message count
  • In the count of unread messages in the room when changing the settings in the backend.

Issue(s)

How to test or reproduce

Set this notification settings in a DM, and receive some messages:
e870b92d-c707-481e-982b-aa43a30b69a1
By setting it like this, if it was the only unread message, the app shouldn't count it as unread in the header. (example of header with unread count)
Screenshot 2024-02-21 at 13 49 47
The other problem is when changing this setting on the web, returning to count the unread count, it was not replicating in the mobile app.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Jira: SUP-451

@dnlsilva dnlsilva marked this pull request as ready for review February 21, 2024 17:22
@dnlsilva dnlsilva merged commit 645b188 into develop Feb 22, 2024
3 of 8 checks passed
@dnlsilva dnlsilva deleted the fix-unread-count branch February 22, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants