[NEW] Default servers improvements #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like the |
|
I'll hang on to this until we find a solution that suits the comments on PR #312, based on installation time server configuration. |
|
I'm happy with the current state of this PR. I tested in several use cases with both Mac and Windows versions, I need to do some testing for linux distros, but it should be working as intended afaik. |
gdelavald
commented
Aug 2, 2017
| @@ -65,10 +65,13 @@ class Servers extends EventEmitter { | |||
|
|
|||
| // Load server info from server config file | |||
| if (Object.keys(hosts).length === 0) { | |||
| const serverFileName = 'servers.json'; | |||
| const userDataDir = jetpack.cwd(remote.app.getPath('userData')); | |||
| const pathToServerJson = jetpack.path( | |||
There was a problem hiding this comment.
Now we check the user APPDATA folder first, then the system installation folder (for /allusers) and then the packaged file (if we do a branded package).
|
+1 THANKS! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #455
Based on Pull Request #471 from @localguru (Thank you so much for this)
Synced with develop to fix the CI build and did a small refactor on the code.