Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow webpack to finish? #28

Closed
atdiff opened this issue Jun 5, 2018 · 9 comments
Closed

Allow webpack to finish? #28

atdiff opened this issue Jun 5, 2018 · 9 comments
Assignees

Comments

@atdiff
Copy link

atdiff commented Jun 5, 2018

Is there a way to allow webpack to still finish processing and exiting out of the build after the notification has appeared? As long as the notification is on the screen, webpack won't complete the process.

@RoccoC
Copy link
Owner

RoccoC commented Jun 6, 2018

Try passing a timeout of 0 in notifyOptions:

new WebpackBuildNotifierPlugin({
    notifyOptions: {
        timeout: 0
    }
})

@atdiff
Copy link
Author

atdiff commented Jun 6, 2018

Didn't appear to make a difference. If I hover over the notification and keep it up, the build still doesn't complete.

@RoccoC
Copy link
Owner

RoccoC commented Jun 22, 2018

Apologies for the delay on this, taking a look today.

@RoccoC
Copy link
Owner

RoccoC commented Jun 30, 2018

@atdiff - this is fixed in 0.1.28. The success notifications will no longer prevent the build from completing.

@RoccoC RoccoC closed this as completed Jun 30, 2018
@atdiff
Copy link
Author

atdiff commented Jul 2, 2018

@RoccoC do I need to still set the notifyOptions timeout to 0?

@atdiff
Copy link
Author

atdiff commented Jul 2, 2018

As long as I keep the notification open and active (moving mouse around the notice), the webpack build doesn't end. But as soon as I close it or allow it to fade away, the build ends shortly after it.

@RoccoC
Copy link
Owner

RoccoC commented Jul 11, 2018

Well crap! No, you shouldn't need to set the timeout to 0.

But, the change I made will only prevent the success notifications from holding up the build; errors or warnings will still hold the build until the notification is dismissed (this is intentional, so the notification can respond to clicks).

Can you tell me which build of Windows 7 you are on so I can try and reproduce? Works as expected on Win10 here...

@RoccoC RoccoC reopened this Jul 11, 2018
@atdiff
Copy link
Author

atdiff commented Nov 1, 2018

@RoccoC, I'm no longer on a Windows 7 machine. And just tested it with Windows 10 and it worked.

@RoccoC
Copy link
Owner

RoccoC commented Nov 1, 2018

@atdiff , thanks for letting me know. Going to close this one. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants