Recent Sphinx fixes, latest disqus.js #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated disqus.js with their latest universal code. Recent Sphinx versions moved html_static_path insertion from the bottom of HTML documents to the top, causing disqus.js to run before the `<div />` has been loaded. Fixing this by using `$(document).ready()`. Recent Sphinx versions also started ignoring prior html_static_path.append() during `setup(app)` call. Fixed this by appending during `builder-inited` event.
Codecov Report
@@ Coverage Diff @@
## main #15 +/- ##
==========================================
- Coverage 98.11% 98.00% -0.12%
==========================================
Files 2 2
Lines 53 50 -3
Branches 5 6 +1
==========================================
- Hits 52 49 -3
Partials 1 1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated disqus.js with their latest universal code.
Recent Sphinx versions moved html_static_path insertion from the bottom
of HTML documents to the top, causing disqus.js to run before the
<div />has been loaded. Fixing this by using$(document).ready().Recent Sphinx versions also started ignoring prior
html_static_path.append() during
setup(app)call. Fixed this byappending during
builder-initedevent.