Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve question detection #114

Merged
merged 5 commits into from
Jul 2, 2019
Merged

Improve question detection #114

merged 5 commits into from
Jul 2, 2019

Conversation

ec-m
Copy link
Collaborator

@ec-m ec-m commented Jul 2, 2019

Closes #106.

@ec-m ec-m changed the base branch from master to velvet-revolution July 2, 2019 11:49
josephbirkner
josephbirkner reviewed Jul 2, 2019
View reviewed changes
Copy link
Collaborator

@josephbirkner josephbirkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good so far, a bit of smoothing needed (test-case fails + see comments) 🚀

modules/ravestate_nlp/__init__.py Show resolved Hide resolved
modules/ravestate_nlp/__init__.py Show resolved Hide resolved
josephbirkner
josephbirkner approved these changes Jul 2, 2019
View reviewed changes
Copy link
Collaborator

@josephbirkner josephbirkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ec-m ec-m merged commit 19adeaa into velvet-revolution Jul 2, 2019
@josephbirkner josephbirkner deleted the question-detection-improvement branch July 9, 2019 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephbirkner josephbirkner josephbirkner approved these changes

@emlozin emlozin Awaiting requested review from emlozin

@l-laura l-laura Awaiting requested review from l-laura

@NeginsCode NeginsCode Awaiting requested review from NeginsCode

@Toseban Toseban Awaiting requested review from Toseban

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ec-m @josephbirkner