Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal Angular 8 project for the new UI #102

Merged
merged 3 commits into from
Jun 30, 2019
Merged

Conversation

nbasargin
Copy link
Collaborator

Adding a minimal Angular 8 project for the new UI. No Karma, no Protractor, only the essential stuff.
Module name is ravestate_ui_new for now. We will change it to ravestate_ui once the old UI is outdated.

@codecov-io
Copy link

codecov-io commented Jun 3, 2019

Codecov Report

Merging #102 into velvet-revolution will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           velvet-revolution     #102      +/-   ##
=====================================================
+ Coverage              74.87%   74.96%   +0.08%     
=====================================================
  Files                     56       56              
  Lines                   3495     3495              
=====================================================
+ Hits                    2617     2620       +3     
+ Misses                   878      875       -3
Impacted Files Coverage Δ
modules/ravestate/causal.py 92.52% <0%> (-0.47%) ⬇️
modules/ravestate/constraint.py 92.1% <0%> (+0.32%) ⬆️
modules/ravestate_persqa/__init__.py 66.43% <0%> (+0.69%) ⬆️
modules/ravestate/activation.py 89.72% <0%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d233f9b...da1cef4. Read the comment docs.

Copy link
Collaborator

@josephbirkner josephbirkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 Thanks for the Readme!

@josephbirkner josephbirkner changed the base branch from master to velvet-revolution June 11, 2019 16:53
Copy link
Collaborator

@l-laura l-laura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked well on Ubuntu, except for the ng serve issue mentioned in the comments. Nice work :)

modules/ravestate_ui_new/README.md Show resolved Hide resolved
@nbasargin nbasargin requested a review from l-laura June 24, 2019 14:51
@josephbirkner josephbirkner merged commit 3e8104b into velvet-revolution Jun 30, 2019
@josephbirkner josephbirkner deleted the angular-ui branch June 30, 2019 17:30
@josephbirkner josephbirkner restored the angular-ui branch June 30, 2019 17:30
@josephbirkner josephbirkner deleted the angular-ui branch June 30, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants