-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Mavlink git repo, remove hot-patching of mavros and mavlink code #358
Update Mavlink git repo, remove hot-patching of mavros and mavlink code #358
Conversation
Depending on the state of #324 , this may be obsolete.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to revert the target organization in the build then this should be good to go.
I'm still mystified at how I end up with such a long trail of commits. Let me do a little rebasing and I'll push a more surgical update. |
d734edf
to
4c4d003
Compare
For those keeping track at home, I'm able to replicate the build error ( No solution yet... |
Appears to be an upstream change in the parser for docker-buildx v0.19.x (possibly related to the Release note for v0.19.1, though v0.19.1/v0.19.2 do not fix it). These latest versions of buildx don't like the syntax As a hack, pin buildx to v0.18.0 in the Github workflow. Added the fix to this PR rather than starting another because I'm not (much of) a sadist. Simple to cherry-pick the change into #324 if we want to abandon this PR. |
Thanks for working on this. I don't see any problem with pinning the version as a quick fix. Would you be willing to submit an issue so that we don't forget about that? |
ab705d2
into
Robotic-Decision-Making-Lab:main
Changes Made
This PR updates the current
main
which still builds mavros and mavlink from source .... with the understanding that it's not long for this world (Issue #324). But it un-breaks CI until that happens.mavlink
fromhttps://github.com/ros2-gbp/mavlink-gbp-release.git
rather thanmavlink/mav-gdp-release.git
. The latter is out of date.Associated Issues
Please provide a list of all open issues that this PR will close or contribute
toward closing.
Notably, does not fix #324