Use the same ID to unadvertise a topic as was used to advertise it #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple fix for the problem described in RobotWebTools/rosbridge_suite#83
T045T
added a commit
that referenced
this pull request
Jun 4, 2014
fix unadvertising Topics and add some instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was brought up in RobotWebTools/rosbridge_suite#83
Previously, rosbridge couldn't unadvertise any Topics originating from roslib.js because different IDs were used to advertise and unadvertise. This change is tested on Hydro - a
ROSLIB.Topicwill not show up inrostopic listafter it has been unadvertised.Also adds instructions on how to get up-to-date Node.js on older Ubuntu versions