first pass of core module #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ghost
assigned
k-aguete
referenced
this pull request
in k-aguete/roslibjs
Oct 21, 2022
first, ugly, but working pass of URDF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first pass of the core module is complete. The old ros.js has been pulled apart into its respective objects and moved to the new ROSLIB namespace. Note that two API changes will break compatibility but they are relatively easy to find/replace: ROSLIB.Topic (old ros.Topic) and ROSLIB.Service (old ros.Service) now require a Ros handle to be provided as an argument.
Additional goodies included in this pull request is the fill conversion of the ROSLIB namespace within /core, a build file create (using ant) that creates a single roslib.js, roslib.min.js, and generates all JSDOC.