Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RTCPeerConnection as Ros transport library #224

Merged
merged 3 commits into from
Apr 15, 2016

Conversation

aisch
Copy link
Contributor

@aisch aisch commented Apr 15, 2016

closes #223

not sure if this is best way to add this support to roslibjs but with this patch i was able to connect a RTCDataChannel to a rosbridge like e.g.

ros.transportLibrary = peer_connection;
ros.transportOptions = {
  reliable: false,
  ordered: false,
};
ros.connect('rosbridge');

@rctoris rctoris merged commit 167a444 into RobotWebTools:develop Apr 15, 2016
@aisch
Copy link
Contributor Author

aisch commented Apr 15, 2016

@rctoris thanks!

@Interpause
Copy link

https://github.com/RobotWebTools/rosbridge_suite does not seem to have any ICE server implementation for WebRTC, how is this feature intended to be used? I am planning to use WebRTC's DataChannel as well, and would not mind attempting to follow the rosbridge protocol, but I am unclear what the current implementation status is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow Ros.connect to use an RTCPeerConnection/RTCDataChannel
3 participants