Add Urdf features: multiple visuals and material linking #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a visuals property to UrdfLink, which contains all the visual elements found in the link element. This breaks api compatibility, since the visual property is not available anymore.
Urdf has the feature to link to a material, instead of specifying it in full. this is done by providing just a name for a material. This commit will fill the material object with content that is specified in an material element of the same name in the body.
|
|
||
| UrdfMaterial.prototype.assign = function(obj) { | ||
| for( var key in obj ) { |
There was a problem hiding this comment.
This can just be
var assign = require("object-assign");
UrdfMaterial.prototype.assign = function(obj) {
return assign(this, obj);
}
|
Thanks. Updated it. |
rctoris
added a commit
that referenced
this pull request
Mar 9, 2015
Add Urdf features: multiple visuals and material linking
k-aguete
pushed a commit
to k-aguete/roslibjs
that referenced
this pull request
Oct 21, 2022
Urdf: add method unsubscribeTf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits will add missing Urdf features. Note that this will break api compatibility, since the UrdfLink.visual param is missing. I am adding a PR to ros3djs as well.