-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid import of get_parameter_value in rosapi for ROS2 Jazzy. #932
Conversation
Signed-off-by: David Oberacker <[email protected]>
Signed-off-by: David Oberacker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This works for rolling (i checked, Iron and later) but we'll have to make another branch for humble since it does not work there.
I am still getting that same error: " ImportError: cannot import name 'get_parameter_value' from 'ros2param.api'"
|
This was only merged to the repo, not released as binaries. You should clone this repo and build it from source. |
Can we get a new release for jazzy that includes this fix? |
When trying to build from source, I got this error:
which is being trigger by this command: If I switch from Rolling to Jazzy, building from source works, and launching the bridge also works. |
Public API Changes
None
Description
The import ros2param.get_parameter_value is no longer valid in ROS2 jazzy.
The code was removed with PR ros2/ros2cli#866, with the suggested alternative being the import from rclpy.
As get_parameter_value was implemented in rclpy for ROS2 versions before Jazzy, this should not break older ROS2 distros.
#926