added topic and service names to warnings #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te debugability; minor linting
jihoonl
requested review from
nuclearsandwich and
jihoonl
and removed request for
nuclearsandwich
jihoonl
approved these changes
Aug 30, 2017
|
Test will be fixed by #287 |
jihoonl
added a commit
that referenced
this pull request
Aug 30, 2017
* Added new parameters for topic and service security. Added 3 new parameters to rosapi and rosbridge_server which filter the topics, services, and parameters broadcast by the server to match an array of glob strings. * Two minor fixes. * Fixed time object field definitions to match documentation. * As per the suggestions of @T045T, fixed several typos, improved logging, and made some style fixes. * Added services_glob to CallServices, added globs to rosbridge_tcp and rosbridge_udp, and other miscellanous fixes. * add missing imports and correct default values for glob parameters * correct default values for security globs also accept empty list as the default "do not check globs" value in addition to None. Finally, append rosapi service glob after processing command line input so it's not overwritten * add missing import * adjust log level for security globs Normal operation (i.e. no globs or successful verification of requests) is now silent, with illegal requests producing a warning. * new service: get actionlib servers * no rospy needed, just for debug logging * Delay unregister to mitigate !138 * Fix: Set default to publish all topics Without better doc, one does not understand why no topics are published. I thought, something is broken. With this defaults, everything is working out of the box. And for a more secure setup, one can change it. * Added default topics to all launch files, and fixed bug where it would crash if nothing was put into the lists as values * Added bug fix in rosapi * Fixed the launch files for the tcp and udp service. Without these modifications, the rosapi node fails because some rosparams are not defined properly before. Now the launchfiles comply to the websocket version. * update changelog * 0.7.17 * Implemented a bson_only_mode flag for the TCP version of rosbridge; This allows you to switch to a full-duplex transmission of BSON messages and therefore eliminates the need for a base64 encoding of binary data; Use the new mode by starting:'roslaunch rosbridge_server rosbridge_tcp.launch bson_only_mode:=True' or passing '--bson_only_mode' to the rosbridge_tcp.py script * minor change in variable usage * Move UNREGISTER_TIMEOUT to member class so it's accessible from outside * Fix missing tests due to delayed unregistration * Fix test advertise errors after delayed unregister changes * Reduce timeout for tests Tests will sleep for 10% extra of the timeout to prevent some situations were the test sleep ended right before the unregister timer fired * Change class constant to module constant * Update protocol.py Prevent a KeyError when bson_only_mode is unset. * Set default for bson_only_mode in websocket handler and launch file. * Create README.md * Update README.md Formatting and examples * don't try to set TCP nodelay option for UDP * expose binary_encoder rosparam that was hidden in deep depth * correct the possible argument * address review comment. more explicitly describe valid args * Cleaning up travis configuration (#283) configure travis to use industial ci configuration. Now it uses xenial and kinetic * fix delete_param in rosapi (#284) * added topic and service names to warnings in order to improve immediate debugability; minor linting (#286) * Fixing errors in test. (#287) * appease call service using timeout and proper arrival waiting * add queue_size on publisher * test them individually. * add time after wait for service * update changelog * 0.8.0 * remove ujson from dependency to build in trusty (#290) * update changelog * 0.8.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added topic and service names to warnings in order to improve immediate debugability; minor linting