Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THREE r89 #252

Merged
merged 3 commits into from
Feb 1, 2019
Merged

THREE r89 #252

merged 3 commits into from
Feb 1, 2019

Conversation

mvollrath
Copy link
Contributor

@mvollrath mvollrath commented Jan 30, 2019

Fixes unicode character issue in r88.

@mvollrath mvollrath requested review from jihoonl and viktorku January 30, 2019 01:49
@mvollrath
Copy link
Contributor Author

I've made a branch with updated builds for this PR: https://github.com/EndPointCorp/ros3djs/tree/three_89_build_test

I've tested visualizer things with success:

  • OccupancyGrid
  • PointCloud2
  • Urdf
  • Grid
  • SceneNode
  • MarkerArray

@jihoonl @viktorku if the THREE build error is going to block release, I'd appreciate your support on this PR.

@jihoonl jihoonl merged commit 7b02e44 into RobotWebTools:develop Feb 1, 2019
@jihoonl
Copy link
Member

jihoonl commented Feb 9, 2019

r89 is now current three.js served by our cdn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants