Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some compilation warnings generated by: node-gyp rebuild #734

Merged
merged 2 commits into from
Nov 21, 2020
Merged

Fix some compilation warnings generated by: node-gyp rebuild #734

merged 2 commits into from
Nov 21, 2020

Conversation

felixdivo
Copy link
Contributor

Fix #733.

@felixdivo felixdivo mentioned this pull request Nov 21, 2020
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 91.207% when pulling b6849ea on felixdivo:fix-compilation-warnings into b09a171 on RobotWebTools:develop.

minggangw
minggangw approved these changes Nov 21, 2020
View reviewed changes
Copy link
Member

@minggangw minggangw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, lgtm

@minggangw minggangw merged commit 30bfd98 into RobotWebTools:develop Nov 21, 2020
minggangw pushed a commit that referenced this pull request Nov 26, 2020
@felixdivo
Fix some compilation warnings generated by: node-gyp rebuild (#734)
e0020d6 
* fix compiler wrning in ActionProcessCancelRequest() by explicitly logging an error
* remove unused (and misnamed) variable

Fix #733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minggangw minggangw minggangw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the compilation warnings generated by: node-gyp rebuild
3 participants
@felixdivo @coveralls @minggangw