Add countPublishers and countSubscribers to Node #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why AppVeyor keeps timing out. Does this happen a lot? Tests work fine locally on both Linux and Windows.
|
|
The ut running on AppVeyor seems less stable than the local one, sometimes, the tests, which aim to verify the interaction between rclnodejs client and rclpy/rclcpp clients, tend to cause the failures (usually timeout). I am going to re-run it again. |
minggangw
approved these changes
Feb 11, 2020
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds countPublishers and countSubscribers which was missing from the Node class. rclpy implementation can be found here for comparison.
Fix #None