Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add testing for NumPy >= 2 #73

Conversation

EricCousineau-TRI
Copy link
Collaborator

@EricCousineau-TRI EricCousineau-TRI commented Jul 8, 2024

Follow-up to #72


This change is Reviewable

@EricCousineau-TRI EricCousineau-TRI force-pushed the feature-test-numpy-2 branch 4 times, most recently from 86a157c to 7750010 Compare July 9, 2024 00:07
Copy link
Collaborator Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @EricCousineau-TRI)

a discussion (no related file):
Working: Going to to revert to master to ensure that NumPy >= 2 works.


Upstream tests NumPy >= 2 on different platforms, so we must repeat it
manually
@EricCousineau-TRI EricCousineau-TRI marked this pull request as ready for review July 9, 2024 01:12
Copy link
Collaborator Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, all discussions resolved

a discussion (no related file):

Previously, EricCousineau-TRI (Eric Cousineau) wrote…

Working: Going to to revert to master to ensure that NumPy >= 2 works.

Done.


@EricCousineau-TRI
Copy link
Collaborator Author

Added testing, will go ahead and merge
FYI @jwnimmer-tri

@EricCousineau-TRI EricCousineau-TRI self-assigned this Jul 9, 2024
Copy link
Collaborator Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@EricCousineau-TRI :lgtm: self-stamp

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EricCousineau-TRI)

@EricCousineau-TRI EricCousineau-TRI merged commit 51d715e into RobotLocomotion:drake Jul 9, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant