Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install install_prereqs_binary_distribution.sh #7917

Merged
merged 1 commit into from
Feb 1, 2018
Merged

Install install_prereqs_binary_distribution.sh #7917

merged 1 commit into from
Feb 1, 2018

Conversation

jamiesnape
Copy link
Contributor

@jamiesnape jamiesnape commented Jan 31, 2018

Relates RobotLocomotion/drake-external-examples#61.


This change is Reviewable

@jamiesnape jamiesnape added component: distribution Nightly binaries, monthly releases, docker, installation unused team: kitware labels Jan 31, 2018
@jwnimmer-tri
Copy link
Collaborator

jwnimmer-tri commented Jan 31, 2018

:lgtm: feature for Ubuntu and platform, if that helps.

Note that the installed install_prereqs is missing executable bits for me. (Not sure if you want those set or not.)

I didn't test if the script was minimal and/or sufficient starting from a clean Ubuntu, but I don't think that needs to be in scope here (and is likely already correct).

@jamiesnape
Copy link
Contributor Author

Note that the installed install_prereqs is missing executable bits for me. (Not sure if you want those set or not.)

I do. I will fix that.

@jamiesnape
Copy link
Contributor Author

+@soonho-tri for feature review on Mac.

@jwnimmer-tri
Copy link
Collaborator

I will fix that.

Confirmed; its 775 now.


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jamiesnape
Copy link
Contributor Author

Yes, quick fix of setting the executable bits on the source file is in. Perhaps more robust would be to add the ability to set permissions in install_files. You could argue either way with whether install_prereqs_binary_distribution.sh should be executable in this repo. We have not really followed GSG with script naming and permissions so far.

@soonho-tri
Copy link
Member

:lgtm: (checked the installation part on 🍎 )


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@soonho-tri soonho-tri merged commit b2f1e6b into RobotLocomotion:master Feb 1, 2018
@jamiesnape jamiesnape deleted the install-install-prereqs branch February 8, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: distribution Nightly binaries, monthly releases, docker, installation unused team: kitware
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants