Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Resources can be found in install tree based on libdrake.so location" #7637

Closed
wants to merge 1 commit into from

Conversation

soonho-tri
Copy link
Member

@soonho-tri soonho-tri commented Dec 18, 2017

This reverts commit a422f25.


Dear @fbudin69500,

The on-call build cop, @soonho-tri, believes that your PR #7439 may have
broken one or more of Drake's continuous integration builds [1,2]. It is
possible to break a build even if your PR passed continuous integration
pre-merge because additional platforms and tests are built post-merge.

The specific build failures under investigation are:
https://drake-jenkins.csail.mit.edu/view/Nightly%20Production/job/mac-sierra-clang-bazel-nightly-debug/142/

Therefore, the build cop has created this revert PR and started a complete
post-merge build to determine whether your PR was in fact the cause of the
problem. If that build passes, this revert PR will be merged 60 minutes from
now. You can then fix the problem at your leisure, and send a new PR to
reinstate your change.

If you believe your original PR did not actually break the build, please
explain on this thread.

If you believe you can fix the break promptly in lieu of a revert, please
explain on this thread, and send a PR to the build cop for review ASAP.

If you believe your original PR definitely did break the build and should be
reverted, please review and LGTM this PR. This allows the build cop to merge
without waiting for CI results.

For advice on how to handle a build cop revert, see [3].

Thanks!
Your Friendly Oncall Buildcop

[1] CI Continuous Production Dashboard: https://drake-jenkins.csail.mit.edu/view/Continuous%20Production/
[2] CI Nightly Production Dashboard: https://drake-jenkins.csail.mit.edu/view/Nightly%20Production/
[3] http://drake.mit.edu/buildcop.html#workflow-for-handling-a-build-cop-revert


This change is Reviewable

@soonho-tri
Copy link
Member Author

@drake-jenkins-bot mac-highsierra-clang-bazel-experimental-everything please
@drake-jenkins-bot mac-sierra-clang-bazel-experimental please

@soonho-tri
Copy link
Member Author

For the record, the problem is only reproducible on a mac with the following step and error messages:

$ bazel test //examples/kuka_iiwa_arm:dual_kuka_simulation_test -c dbg

...

INFO: From Testing //examples/kuka_iiwa_arm:dual_kuka_simulation_test:
==================== 
Test output for //examples/kuka_iiwa_arm:dual_kuka_simulation_test:
ERROR: something wrong with flag 'flagfile' in file
'external/com_github_gflags_gflags/src/gflags.cc'.  
One possibility: file 'external/com_github_gflags_gflags/src/gflags.cc' 
is being linked both statically and dynamically into this executable.

@drake-jenkins-bot
Copy link

Jenkins build failed

1 similar comment
@drake-jenkins-bot
Copy link

Jenkins build failed

@soonho-tri
Copy link
Member Author

@drake-jenkins-bot mac-highsierra-clang-bazel-experimental-everything please
@drake-jenkins-bot mac-sierra-clang-bazel-experimental please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants