Switch to ignition-math4. #7622
Conversation
|
@caguero FYI |
|
@drake-jenkins-bot mac-highsierra-clang-bazel-experimental-everything please |
|
@drake-jenkins-bot mac-highsierra-clang-bazel-experimental-everything please |
clalancette
force-pushed
the
ignition-math4
branch
from
25156b7 to
dbc9419
Compare
|
Rebased onto the latest. |
|
@drake-jenkins-bot mac-highsierra-clang-bazel-experimental-everything please |
|
@drake-jenkins-bot retest this please |
|
@drake-jenkins-bot mac-highsierra-clang-bazel-experimental-everything please |
|
@drake-jenkins-bot linux-xenial-clang-bazel-experimental-debug please |
clalancette
force-pushed
the
ignition-math4
branch
from
dbc9419 to
3f91c0a
Compare
|
+@jamiesnape for feature review. |
|
Reviewed 7 of 7 files at r1. Comments from Reviewable |
|
@drake-jenkins-bot mac-highsierra-clang-bazel-experimental please |
|
+@ggould-tri for platform review. |
|
Review status: all files reviewed at latest revision, 1 unresolved discussion. tools/workspace/ignition_math/ignition_math.BUILD.bazel, line 54 at r1 (raw file):
I'm confused by this name. Why do we call it Comments from Reviewable |
This is going to be needed to move to newer versions of ignition libraries, newer sdformat, and for delphyne going forward. While we are at it, make ignition-math a shared library. Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
|
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. tools/workspace/ignition_math/ignition_math.BUILD.bazel, line 54 at r1 (raw file): Previously, ggould-tri wrote…
Yeah, good point. I'll move the Comments from Reviewable |
clalancette
force-pushed
the
ignition-math4
branch
from
3f91c0a to
a192dce
Compare
|
@drake-jenkins-bot mac-highsierra-clang-bazel-experimental please |
|
Reviewed 2 of 2 files at r2, 1 of 1 files at r3. Comments from Reviewable |
|
This passed review, and passes all tests. I'm not sure what the merge procedure is (@jwnimmer-tri has merged all of my PRs in the past). Should I just go ahead and merge it? |
|
If the merge button in the upper right is green, go ahead and hit it. Review status: Comments from Reviewable |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
|
I see the green button, so I'll merge. Thanks @ggould-tri . Review status: Comments from Reviewable |
This is going to be needed to move to newer versions of ignition
libraries, newer sdformat, and for delphyne going forward. While
we are at it, make ignition-math a shared library.
Signed-off-by: Chris Lalancette [email protected]
This change is