Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup drake.cps #7454

Merged
merged 1 commit into from
Nov 10, 2017
Merged

Cleanup drake.cps #7454

merged 1 commit into from
Nov 10, 2017

Conversation

jamiesnape
Copy link
Contributor

@jamiesnape jamiesnape commented Nov 10, 2017

Per the list in #7451, some entries can be cleaned up from drake.cps since they are both private and correctly linked into libdrake.so. Equally, optitrack is used by a public header and so should appear in drake.cps.


This change is Reviewable

@jamiesnape
Copy link
Contributor Author

+@fbudin69500 for feature review.

@jamiesnape jamiesnape added unused team: kitware component: distribution Nightly binaries, monthly releases, docker, installation labels Nov 10, 2017
@fbudin69500
Copy link

:lgtm:


Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jamiesnape
Copy link
Contributor Author

+@sherm1 for platform review.

@sherm1
Copy link
Member

sherm1 commented Nov 10, 2017

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@sherm1 sherm1 merged commit f7a11e2 into RobotLocomotion:master Nov 10, 2017
@jamiesnape jamiesnape deleted the cleanup-drake-cps branch November 17, 2017 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: distribution Nightly binaries, monthly releases, docker, installation unused team: kitware
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants