Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purge CMake not used by MATLAB #6738

Merged
merged 1 commit into from
Sep 29, 2017
Merged

Purge CMake not used by MATLAB #6738

merged 1 commit into from
Sep 29, 2017

Conversation

jamiesnape
Copy link
Contributor

@jamiesnape jamiesnape commented Aug 1, 2017 •
edited
Loading

Toward #3129. Closes #3342, closes #3426, closes #4113, closes #4525, closes #5356, and closes #5572.

This change is Reviewable

@jamiesnape jamiesnape self-assigned this Aug 1, 2017
@jamiesnape jamiesnape changed the title Purge CMake not used by MATLAB Purge CMake not used by MATLAB and/or ROS Aug 1, 2017
@jamiesnape
Copy link
Contributor Author

+@fbudin69500 and +@jwnimmer-tri for feature review.

@jwnimmer-tri
Copy link
Collaborator

FYI I will trust that Spartan / Director are well in hand, so I've only focused on the in-tree repercussions, which :lgtm:. You can count me as platform review also.

Reviewed 93 of 93 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@fbudin69500
Copy link

:lgtm:

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@stonier
Copy link
Contributor

stonier commented Aug 5, 2017

As far as I understand, this should not go in before RobotLocomotion/spartan#116 gets merged and has had a brief period of usage to resolve any hiccups.

Comments from Reviewable

@patmarion
Copy link
Member

As far as I understand, this should not go in before RobotLocomotion/spartan#116 gets merged and has had a brief period of usage to resolve any hiccups.

There are no plans in spartan to update the required version of drake except via RobotLocomotion/spartan#116 so i don't think spartan needs to be a blocking issue.

@stonier
Copy link
Contributor

stonier commented Aug 6, 2017

I would prefer RobotLocomotion/spartan#116 to go in first so if Spartan users do suddenly want a bump of Drake, they don't have a blocking delay of unknown duration in getting it.

@jamiesnape
Copy link
Contributor Author

Yes, note the "do not merge" tag. This will not merge until the Spartan PR is in.

@jamiesnape jamiesnape mentioned this pull request Aug 8, 2017
Closed
@jamiesnape jamiesnape changed the title Purge CMake not used by MATLAB and/or ROS Purge CMake not used by MATLAB Aug 15, 2017
@jamiesnape
Copy link
Contributor Author

Fixing merge conflicts and consolidating with #6788 since ROS support is gone post-#6783.

@jwnimmer-tri
Copy link
Collaborator

Reviewed 9 of 10 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@jamiesnape
Copy link
Contributor Author

More merge conflicts.

@jwnimmer-tri
Copy link
Collaborator

Reviewed 4 of 4 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@jwnimmer-tri
Copy link
Collaborator

Reviewed 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@jamiesnape jamiesnape merged commit 33feef7 into RobotLocomotion:master Sep 29, 2017
@jamiesnape jamiesnape deleted the purge-cmake-1 branch September 29, 2017 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fbudin69500 fbudin69500

@jwnimmer-tri jwnimmer-tri

Labels
configuration: cmake status: do not merge unused team: kitware
Projects
None yet
Milestone
No milestone
5 participants
@jamiesnape @jwnimmer-tri @fbudin69500 @stonier @patmarion