Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libbot Enabled out of source builds. #2777

Merged
merged 2 commits into from
Jul 14, 2016

Conversation

jhoare
Copy link

@jhoare jhoare commented Jul 11, 2016

Updated CMakeLists.txt for libbot to not pollute the source tree.

CI PR for RobotLocomotion/libbot#18

Provides progress towards #1859


This change is Reviewable

@jhoare
Copy link
Author

jhoare commented Jul 12, 2016

@sherm1 for platform review (feel free to re-assign if necessary)

@david-german-tri
Copy link
Contributor

-@sherm1, +@RussTedrake (build system PR). Looks reasonable to me, for what it's worth.

@liangfok
Copy link
Contributor

:lgtm:


Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@liangfok
Copy link
Contributor

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@RussTedrake
Copy link
Contributor

tested this one out. and 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: distribution Nightly binaries, monthly releases, docker, installation priority: medium type: cleanup unused team: kitware
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants