Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[workspace] Upgrade pybind11 to latest commit #21584

Merged
merged 1 commit into from
Jun 18, 2024
Merged

[workspace] Upgrade pybind11 to latest commit #21584

merged 1 commit into from
Jun 18, 2024

Conversation

EricCousineau-TRI
Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI commented Jun 18, 2024 •
edited by sherm1
Loading

Towards #21577

This change is Reviewable

EricCousineau-TRI
EricCousineau-TRI commented Jun 18, 2024
View reviewed changes
Copy link
Contributor Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, missing label for release notes (waiting on @EricCousineau-TRI)

a discussion (no related file):
Working: Requires RobotLocomotion/pybind11#71

@jwnimmer-tri
Copy link
Collaborator

I pushed a lint fix to unblock CI results. Feel free to squash & force-push it away anytime.

@EricCousineau-TRI EricCousineau-TRI marked this pull request as ready for review June 18, 2024 17:16
@EricCousineau-TRI EricCousineau-TRI added the status: single reviewer ok https://drake.mit.edu/reviewable.html label Jun 18, 2024
EricCousineau-TRI
EricCousineau-TRI commented Jun 18, 2024
View reviewed changes
Copy link
Contributor Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! updated to merged commit
+@jwnimmer-tri for +(status: single reviewer ok) review please

Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), missing label for release notes (waiting on @EricCousineau-TRI)

jwnimmer-tri
jwnimmer-tri reviewed Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: both. Thanks for this! I'll launch some extra builds momentarily.

Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: missing label for release notes (waiting on @EricCousineau-TRI)

@jwnimmer-tri jwnimmer-tri added the release notes: fix This pull request contains fixes (no new features) label Jun 18, 2024
@jwnimmer-tri
Copy link
Collaborator

@drake-jenkins-bot linux-jammy-unprovisioned-gcc-wheel-experimental-release please
@drake-jenkins-bot mac-arm-ventura-unprovisioned-clang-wheel-experimental-release please

@jwnimmer-tri
Copy link
Collaborator

The macOS failure is known flake #19335.

@jwnimmer-tri jwnimmer-tri merged commit 38090a8 into RobotLocomotion:master Jun 18, 2024
10 of 11 checks passed
joemasterjohn pushed a commit to joemasterjohn/drake that referenced this pull request Jul 1, 2024
@EricCousineau-TRI @joemasterjohn
[workspace] Upgrade pybind11 to latest commit (RobotLocomotion#21584)
7b9acf1
RussTedrake pushed a commit to RussTedrake/drake that referenced this pull request Dec 15, 2024
@EricCousineau-TRI @RussTedrake
[workspace] Upgrade pybind11 to latest commit (RobotLocomotion#21584)
a4324de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwnimmer-tri jwnimmer-tri jwnimmer-tri left review comments

Assignees

@jwnimmer-tri jwnimmer-tri

Labels
release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EricCousineau-TRI @jwnimmer-tri