Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Add rules_license 0.0.7 #20560

Merged

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Nov 17, 2023

See also bazelbuild/platforms#82.


This change is Reviewable

This is required by the `@platforms` external. In modern versions of
Bazel a sufficiently new version of `@rules_license` is built-in, but
the older Bazel 5.x series will fail without this. In any case, we
should affirmatively control the versions of all of our dependencies,
so relying on the built-in one is poor form anyway.
@jwnimmer-tri jwnimmer-tri added priority: low status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: fix This pull request contains fixes (no new features) labels Nov 17, 2023
@jwnimmer-tri
Copy link
Collaborator Author

+@rpoyner-tri for both reviews per schedule (Tuesday), please.

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform)

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee rpoyner-tri(platform)

@rpoyner-tri rpoyner-tri merged commit f6e1a72 into RobotLocomotion:master Nov 21, 2023
10 checks passed
@jwnimmer-tri jwnimmer-tri deleted the workspace-rules_license branch November 21, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants