Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wheel] macOS arm64 staging builds use Ventura now #20520

Conversation

svenevs
Copy link
Contributor

@svenevs svenevs commented Nov 10, 2023

Relates: #20339

This is an implication of switching the wheel build as far as I know. We have not had nightly CI finish yet which will be the first CI job capable of producing an artifact similar to the staging urls being considered.

CC @BetsyMcPhail @jwnimmer-tri


This change is Reviewable

@svenevs svenevs added the release notes: none This pull request should not be mentioned in the release notes label Nov 10, 2023
Copy link
Contributor Author

@svenevs svenevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@mwoehlke-kitware for review please. Continuing the thread from #20339 (comment), we can test this change once we have ventura runners available in CI (tomorrow...).

Reviewable status: 1 unresolved discussion, LGTM missing from assignee mwoehlke-kitware, needs platform reviewer assigned, needs at least two assigned reviewers


tools/release_engineering/download_release_candidate.py line 140 at r1 (raw file):

            f"drake-{version[1:]}-cp312-cp312-manylinux_2_31_x86_64.whl",
            f"drake-{version[1:]}-cp311-cp311-macosx_12_0_x86_64.whl",
            f"drake-{version[1:]}-cp311-cp311-macosx_13_0_arm64.whl",

working, we do not have enough CI runners to test this change today.

Copy link
Contributor

@mwoehlke-kitware mwoehlke-kitware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge" (waiting on @svenevs)

Copy link
Contributor

@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge" (waiting on @svenevs)

@jwnimmer-tri
Copy link
Collaborator

jwnimmer-tri commented Nov 10, 2023

:lgtm:

@jwnimmer-tri jwnimmer-tri self-assigned this Nov 10, 2023
Copy link
Contributor Author

@svenevs svenevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: labeled "do not merge"

@svenevs
Copy link
Contributor Author

svenevs commented Nov 10, 2023

[3:31:24 PM]  -- Artifacts uploaded to AWS:
[3:31:24 PM]  https://drake-packages.csail.mit.edu/drake/nightly/drake-0.0.20231110-cp311-cp311-macosx_13_0_arm64.whl
[3:31:24 PM]  https://drake-packages.csail.mit.edu/drake/nightly/drake-latest-cp311-cp311-macosx_13_0_arm64.whl
[3:31:24 PM]  

@svenevs svenevs merged commit 7d55aff into RobotLocomotion:master Nov 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: none This pull request should not be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants