[workspace] Deprecate the expat external #20351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: low
status: single reviewer ok
jwnimmer-tri
force-pushed
the
vtk-expat-deprecation
branch
from
83bc57b
to
05115d2
Compare
|
+@SeanCurtis-TRI for both reviews, please. |
As of df39f12, Drake no longer needs this at all.
jwnimmer-tri
force-pushed
the
vtk-expat-deprecation
branch
from
05115d2
to
3c8eee5
Compare
|
@drake-jenkins-bot linux-focal-unprovisioned-gcc-bazel-experimental-release please @drake-jenkins-bot linux-focal-unprovisioned-gcc-wheel-experimental-release please |
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee SeanCurtis-TRI(platform)
WawasCode
pushed a commit
to WawasCode/drake
that referenced
this pull request
Oct 31, 2023
As of df39f12, Drake no longer needs this at all.
WawasCode
pushed a commit
to WawasCode/drake
that referenced
this pull request
Oct 31, 2023
As of df39f12, Drake no longer needs this at all.
rpoyner-tri
added a commit
to rpoyner-tri/drake
that referenced
this pull request
Dec 3, 2023
…)" This reverts commit 3cfe0b0. This is a temporary crutch for rnv-based schema development. Eventually replace this with a source build of expat.
rpoyner-tri
added a commit
to rpoyner-tri/drake
that referenced
this pull request
Jan 5, 2024
…)" This reverts commit 3cfe0b0. This is a temporary crutch for rnv-based schema development. Eventually replace this with a source build of expat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #19945, Drake no longer needs this at all.
This change is