Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Upgrade stable_baselines3_internal to latest release v1.8.0 #19187

Merged

Conversation

mwoehlke-kitware
Copy link
Contributor

@mwoehlke-kitware mwoehlke-kitware commented Apr 12, 2023

Towards #19137.

Our patches no longer apply and need to be updated.


This change is Reviewable

@jwnimmer-tri
Copy link
Collaborator

+@ggould-tri to finish the patch adjustment changes, please. You can push fixes to this branch.

@jwnimmer-tri jwnimmer-tri added priority: low release notes: fix This pull request contains fixes (no new features) labels Apr 12, 2023
Copy link
Contributor

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, looking into this soon-ish.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee ggould-tri(platform), needs at least two assigned reviewers, labeled "do not merge" (waiting on @mwoehlke-kitware)

@jwnimmer-tri
Copy link
Collaborator

@ggould-tri any progress?

@ggould-tri
Copy link
Contributor

Here is the meta-commentary:

  • OpenAi deprecated gym prior to stabilizing a release with the new API
  • stable-baselines3 had been waiting on that release to complete support for the new API, and we were in turn waiting on sb3.
  • Following their acquisition, OpenAi spun up a new foundation which immediately picked up the briefly abandoned gym to create Gymnasium.
  • The sb3 team judges gymnasium stable enough, and has begun the process of migrating from a gym "backend" to a gymnasium "backend" (there is not clearly a "back" to be on the end of; each of gym and sb3 might reasonably consider the other a backend).
  • Gymnasium 1.0 and sb3 2.0 are both targeted for circa June.

As such, I'm going to try to do something minimal for this PR, in the not-especially-sure-and-certain faith that it's all about to change anyway. The new API is unambiguously superior and we will likely want to migrate to it promptly.

@jwnimmer-tri
Copy link
Collaborator

If there is any difficulty, another option is to set commit_pin = True with a TODO to revisit at a later date.

commit_pin: optional boolean, set to True iff the archive should remain
at the same version indefinitely, eschewing automated upgrades to
newer versions.

@mwoehlke-kitware mwoehlke-kitware mentioned this pull request May 2, 2023
2 tasks
Copy link
Contributor

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to text that worked for me locally. I had some trouble getting the push to branch to work, so we'll see if I got it right...

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: LGTM missing from assignee ggould-tri(platform), needs at least two assigned reviewers, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @ggould-tri and @mwoehlke-kitware)

Copy link
Contributor

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes CI. -(status: do not merge)

Reviewable status: LGTM missing from assignee ggould-tri(platform), needs at least two assigned reviewers, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @ggould-tri and @mwoehlke-kitware)

@ggould-tri ggould-tri added the status: single reviewer ok https://drake.mit.edu/reviewable.html label May 17, 2023
Copy link
Contributor

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this waiting on me? :lgtm: +(status: single reviewer ok) if that's what's needed.

Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @mwoehlke-kitware)

@jwnimmer-tri
Copy link
Collaborator

Yeah, it was waiting for platform review to be assigned, I guess. It looks good to me, also. Feel free to squash and merge.

@ggould-tri ggould-tri added the status: squashing now https://drake.mit.edu/reviewable.html#curated-commits label May 17, 2023
Copy link
Contributor

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+(status: squashing now)

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee ggould-tri(platform)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html status: squashing now https://drake.mit.edu/reviewable.html#curated-commits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants